Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

test: Fixes act errors in AlteredSliceTag test #21392

Merged
merged 1 commit into from
Sep 8, 2022
Merged

test: Fixes act errors in AlteredSliceTag test #21392

merged 1 commit into from
Sep 8, 2022

Conversation

michael-s-molina
Copy link
Member

SUMMARY

This PR fixes 18 act errors in superset-frontend/src/components/AlteredSliceTag.test.tsx

TESTING INSTRUCTIONS

  • Execute the component tests
  • Observe that there are no act errors in the console

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Merging #21392 (b0fd668) into master (0601b2d) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #21392      +/-   ##
==========================================
+ Coverage   66.61%   66.63%   +0.02%     
==========================================
  Files        1791     1791              
  Lines       68538    68559      +21     
  Branches     7310     7319       +9     
==========================================
+ Hits        45655    45685      +30     
+ Misses      21002    20982      -20     
- Partials     1881     1892      +11
Flag Coverage Δ
javascript 52.84% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ard/components/DrillDetailPane/DrillDetailPane.tsx 81.01% <0.00%> (-1.75%) ⬇️
...rset-frontend/src/components/MetadataBar/index.tsx
...rontend/src/components/MetadataBar/MetadataBar.tsx 96.00% <0.00%> (ø)
...board/components/nativeFilters/FilterBar/index.tsx 65.94% <0.00%> (+5.79%) ⬆️
...rd/components/nativeFilters/FilterBar/keyValue.tsx 40.74% <0.00%> (+22.22%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lyndsiWilliams lyndsiWilliams merged commit a95e1c8 into apache:master Sep 8, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@lyndsiWilliams lyndsiWilliams lyndsiWilliams approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michael-s-molina @lyndsiWilliams @mistercrunch